From ee6e8a6fa3f8d494e0e19f17b3a663913fd2342d Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Fri, 24 Jan 2020 00:48:30 +0100 Subject: [PATCH] pam: Better debug when max_tries option is invalid --- pam/pam_fprintd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pam/pam_fprintd.c b/pam/pam_fprintd.c index 2b3bf0b..ab17282 100644 --- a/pam/pam_fprintd.c +++ b/pam/pam_fprintd.c @@ -643,8 +643,13 @@ PAM_EXTERN int pam_sm_authenticate(pam_handle_t *pamh, int flags, int argc, } } else if (str_has_prefix (argv[i], MAX_TRIES_MATCH) && strlen(argv[i]) == strlen (MAX_TRIES_MATCH) + 1) { max_tries = atoi (argv[i] + strlen (MAX_TRIES_MATCH)); - if (max_tries < 1) + if (max_tries < 1) { + if (debug) { + pam_syslog (pamh, LOG_DEBUG, "invalid max tries '%s', using %d", + argv[i] + strlen (MAX_TRIES_MATCH), DEFAULT_MAX_TRIES); + } max_tries = DEFAULT_MAX_TRIES; + } if (debug) pam_syslog (pamh, LOG_DEBUG, "max_tries specified as: %d", max_tries); } else if (str_has_prefix (argv[i], TIMEOUT_MATCH) && strlen(argv[i]) <= strlen (TIMEOUT_MATCH) + 2) {