cookiez/pam-fprint-grosshack
1
0
Fork 0
mirror of https://gitlab.com/mishakmak/pam-fprint-grosshack.git synced 2026-04-08 20:03:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

pam: Remove unneeded assignments

Browse Source 
Don't use return messages for D-Bus calls when we're not interested in
those return values.
This commit is contained in:
Bastien Nocera
2020-01-28 12:02:06 +01:00
parent c2aa5c0b9a
commit 874b4556ef
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pam/pam_fprintd.c
View File

@ -505,7 +505,6 @@ release_device (pam_handle_t *pamh,
const char *dev) const char *dev)
{ {
sd_bus_error error = SD_BUS_ERROR_NULL; sd_bus_error error = SD_BUS_ERROR_NULL;
sd_bus_message *m = NULL;
int r; int r;
r = sd_bus_call_method (bus, r = sd_bus_call_method (bus,
@ -514,17 +513,13 @@ release_device (pam_handle_t *pamh,
"net.reactivated.Fprint.Device", "net.reactivated.Fprint.Device",
"Release", "Release",
&error, &error,
&m, NULL,
NULL, NULL,
NULL); NULL);
if (r < 0) { if (r < 0) {
pam_syslog (pamh, LOG_ERR, "ReleaseDevice failed: %s", error.message); pam_syslog (pamh, LOG_ERR, "ReleaseDevice failed: %s", error.message);
sd_bus_error_free (&error); sd_bus_error_free (&error);
return;
} }
//FIXME needed?
sd_bus_message_unref (m);
} }
static bool static bool
@ -534,7 +529,6 @@ claim_device (pam_handle_t *pamh,
const char *username) const char *username)
{ {
sd_bus_error error = SD_BUS_ERROR_NULL; sd_bus_error error = SD_BUS_ERROR_NULL;
sd_bus_message *m = NULL;
int r; int r;
r = sd_bus_call_method (bus, r = sd_bus_call_method (bus,
@ -543,7 +537,7 @@ claim_device (pam_handle_t *pamh,
"net.reactivated.Fprint.Device", "net.reactivated.Fprint.Device",
"Claim", "Claim",
&error, &error,
&m, NULL,
"s", "s",
username); username);
if (r < 0) { if (r < 0) {
@ -553,9 +547,6 @@ claim_device (pam_handle_t *pamh,
return false; return false;
} }
//FIXME needed?
sd_bus_message_unref (m);
return true; return true;
} }