cookiez/pam-fprint-grosshack
1
0
Fork 0
mirror of https://gitlab.com/mishakmak/pam-fprint-grosshack.git synced 2026-04-08 20:03:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix test not failing on error

Browse Source 
An assertion that is raised within a callback will not be swallowed by
the C code that called the function. To ensure that errors will be
noticable, pass the result back to the surrounding scope and check it
there.
This commit is contained in:
Benjamin Berg
2020-10-02 17:54:20 +02:00
parent e075d37590
commit 6dc699ae6f
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/fprintd.py
View File

@ -427,27 +427,27 @@ class FPrintdManagerPreStartTests(FPrintdTest):
self.manager.GetDefaultDevice() self.manager.GetDefaultDevice()
def test_manager_get_devices_on_name_appeared(self): def test_manager_get_devices_on_name_appeared(self):
self._appeared = False self._appeared_res = []
def on_name_appeared(connection, name, name_owner): def on_name_appeared(connection, name, name_owner):
self._appeared = True self._appeared_res.append(connection.call_sync('net.reactivated.Fprint',
dev_path = connection.call_sync('net.reactivated.Fprint',
'/net/reactivated/Fprint/Manager', '/net/reactivated/Fprint/Manager',
'net.reactivated.Fprint.Manager', 'net.reactivated.Fprint.Manager',
'GetDefaultDevice', None, None, 'GetDefaultDevice', None, None,
Gio.DBusCallFlags.NO_AUTO_START, 500, None) Gio.DBusCallFlags.NO_AUTO_START, 500, None))
self.assertIsNotNone(dev_path)
self.assertTrue(dev_path.startswith('/net/reactivated/Fprint/Device/'))
id = Gio.bus_watch_name_on_connection(self.dbus, id = Gio.bus_watch_name_on_connection(self.dbus,
'net.reactivated.Fprint', Gio.BusNameWatcherFlags.NONE, 'net.reactivated.Fprint', Gio.BusNameWatcherFlags.NONE,
on_name_appeared, None) on_name_appeared, None)
self.daemon_start() self.daemon_start()
while not self._appeared: while not self._appeared_res:
ctx.iteration(True) ctx.iteration(True)
self.assertTrue(self._appeared) self.assertIsNotNone(self._appeared_res[0])
dev_path = self._appeared_res[0][0]
self.assertTrue(dev_path.startswith('/net/reactivated/Fprint/Device/'))
Gio.bus_unwatch_name(id) Gio.bus_unwatch_name(id)