From 5d7422e17aaaf3a0c09fc4a3c8f6fa67371d3130 Mon Sep 17 00:00:00 2001 From: Benjamin Berg Date: Wed, 25 Aug 2021 13:43:30 +0200 Subject: [PATCH] tests: Cleanup inhibitor fifo properly Unlink the fifo itself and use addCleanup to close it. --- tests/fprintd.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fprintd.py b/tests/fprintd.py index a274793..f0dbc7b 100644 --- a/tests/fprintd.py +++ b/tests/fprintd.py @@ -601,7 +601,9 @@ class FPrintdVirtualDeviceBaseTest(FPrintdVirtualImageDeviceBaseTests): fifo_path = os.path.join(self.tmpdir, 'logind_inhibit_fifo') os.mkfifo(fifo_path) + self.addCleanup(os.unlink, fifo_path) self.logind_inhibit_fifo = os.open(fifo_path, os.O_RDONLY | os.O_NONBLOCK | os.O_CLOEXEC) + self.addCleanup(os.close, self.logind_inhibit_fifo) # EOF without a writer, BlockingIOError with a writer self.assertFalse(self.holds_inhibitor()) @@ -662,8 +664,6 @@ class FPrintdVirtualDeviceBaseTest(FPrintdVirtualImageDeviceBaseTests): self.device = None self.manager = None - os.close(self.logind_inhibit_fifo) - super().tearDown() def try_release(self):